andygrove commented on code in PR #5634:
URL: https://github.com/apache/datafusion-comet/pull/5634#discussion_r4232986455


##########
dev/diffs/4.1.3.diff:
##########
@@ -423,28 +474,63 @@ index 0d807aeae4d..6d7744e771b 100644
    }
  
    test("A cached table preserves the partitioning and ordering of its cached 
SparkPlan") {
-@@ -1673,9 +1674,18 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils
+@@ -1595,7 +1602,8 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils
+     }
+   }
+ 
+-  test("SPARK-36120: Support cache/uncache table with TimestampNTZ type") {
++  test("SPARK-36120: Support cache/uncache table with TimestampNTZ type",
++    IgnoreComet("Comet's cache format reports Arrow buffer sizes")) {

Review Comment:
   SPARK-37371 had the same problem, so b798f443c5 narrows it too. It now skips 
only the columnar checks on the union of the two cached relations, which Comet 
runs as a `CometUnion` over its own cache scans. The union with a local 
relation stays Spark's non-columnar `UnionExec` under Comet, so that check and 
both answer checks still run. It passes locally with Comet on 3.5, 4.0, 4.1 and 
4.2.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to