viirya commented on code in PR #897:
URL: https://github.com/apache/datafusion-comet/pull/897#discussion_r1739201839
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -95,6 +95,10 @@ class CometSparkSessionExtensions
plan
} else {
plan.transform {
+ case scanExec: FileSourceScanExec if
scanExec.partitionFilters.nonEmpty =>
Review Comment:
Not all partition filters are DPP filter. They are probably pushed down
filters.
In Spark, `DataSourceScanExec` has a check we can use:
```
private def isDynamicPruningFilter(e: Expression): Boolean =
e.exists(_.isInstanceOf[PlanExpression[_]])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
