andygrove commented on code in PR #897: URL: https://github.com/apache/datafusion-comet/pull/897#discussion_r1739250831
########## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ########## @@ -95,6 +95,10 @@ class CometSparkSessionExtensions plan } else { plan.transform { + case scanExec: FileSourceScanExec if scanExec.partitionFilters.nonEmpty => Review Comment: The test in this PR does not trigger DPP when using v2 data source. I read that DPP is more optimized for v1 but not sure if that is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org