Samearth17 commented on PR #6651: URL: https://github.com/apache/datafusion-comet/pull/6651#issuecomment-6093816688
Addressed the review by moving the duplicate-field end-to-end coverage into `from_json_duplicate_fields.sql`. The fixture opts into native `JsonToStructs`, checks top-level and nested duplicate schemas with `expect_fallback(unsupported output type)`, and keeps a distinct-name native-path control; the low-level production guard remains covered separately. Validation: `./mvnw spotless:check -DskipTests` passed and `git diff --check` passed. I also ran the focused `CometSqlFileTestSuite` under JDK 17; this macOS checkout has no built Comet native library (`native/target/*-apple-darwin` is absent), so the local plan had no native/fallback annotations and the end-to-end assertion could not complete. CI will provide the native execution check. Pushed head: `a44439f8fd414b4c720a77079d16b63ec47efecf`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
