alamb commented on code in PR #12275:
URL: https://github.com/apache/datafusion/pull/12275#discussion_r1740095437
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -120,6 +120,7 @@ pub enum TypeSignature {
/// Fixed number of arguments of numeric types.
/// See
<https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#method.is_numeric>
to know which type is considered numeric
Numeric(usize),
+ Float(usize),
Review Comment:
One minor comment is perhaps we should call this `Float64` to be explicit
that the argument will be 64 bit (rather than maybe f32 or maybe f64)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
