jayzhan211 commented on code in PR #12275:
URL: https://github.com/apache/datafusion/pull/12275#discussion_r1740097490
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -120,6 +120,7 @@ pub enum TypeSignature {
/// Fixed number of arguments of numeric types.
/// See
<https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#method.is_numeric>
to know which type is considered numeric
Numeric(usize),
+ Float(usize),
Review Comment:
I'm concern that we will ends up with specific signature Float32, Float64,
Float16... Another idea I'm working on is introducing
`TypeSignature::Coercible(Vec<DataType>)`, similar to Exact but try to coerce
to target type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
