jayzhan211 commented on code in PR #12256: URL: https://github.com/apache/datafusion/pull/12256#discussion_r1740341356
########## datafusion/physical-plan/src/aggregates/mod.rs: ########## @@ -2489,4 +2497,49 @@ mod tests { Ok(()) } + + #[test] + fn group_exprs_nullable() -> Result<()> { Review Comment: I think it is possible to add the test in slt 🤔 ? Only create rust test if it is not trivial to add test in slt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org