viirya commented on code in PR #6563: URL: https://github.com/apache/datafusion-comet/pull/6563#discussion_r4251527492
########## spark/src/test/resources/sql-tests/expressions/array/array_set_signed_zero_spark_4_0_4_1.sql: ########## @@ -18,9 +18,10 @@ -- MinSparkVersion: 4.0 -- MaxSparkVersion: 4.1 --- 4.0.0-4.0.4 and 4.1.0-4.1.3 keep signed zeros distinct. 4.0.5+ and 4.1.4+ normalize during --- evaluation (SPARK-59602), which native distinct/union do not match for NaNs or nested zeros, so --- distinct/union fall back on every 4.0 and 4.1 release. +-- 4.0.0-4.0.4 and 4.1.0-4.1.3 keep signed zeros distinct, so distinct/union fall back there. +-- 4.0.5+ and 4.1.4+ normalize during evaluation (SPARK-59602), and distinct/union run natively. +-- Which path runs depends on the patch release, so these cases check only the answer; Review Comment: Thanks for running all three RCs, and for checking the native path directly with the `query` copy of this fixture. That covers what I was after. Good catch on `arrays_overlap` too. #6768 and #6769 look like the right place for those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
