andygrove commented on code in PR #6887:
URL: https://github.com/apache/datafusion-comet/pull/6887#discussion_r4248862614
##########
spark/src/test/scala/org/apache/comet/CometS3TestBase.scala:
##########
@@ -46,7 +47,11 @@ trait CometS3TestBase extends CometTestBase {
protected def testBucketName: String
override def beforeAll(): Unit = {
- minioContainer = new
MinIOContainer(DockerImageName.parse("minio/minio:latest"))
+ // Docker Hub no longer serves minio/minio, so use Chainguard's build of
the same server.
+ minioContainer = new MinIOContainer(
+ DockerImageName
+ .parse("cgr.dev/chainguard/minio:latest")
Review Comment:
Nit, optional: Could we pin this by digest rather than `latest`, the way
Trino does (`cgr.dev/chainguard/minio@sha256:...` with a comment naming the
MinIO release)? Chainguard rebuilds `latest` from its fork regularly, and the
fork is still tightening request checks. Its 2026-09-22 release started
rejecting unsigned `x-amz-*` headers in SigV4 verification. Once #5365's Delta
S3 job runs on this fixture, a rebuild could turn it red with no change on our
side. A digest also means everyone runs these suites against the same server.
It should be the multi-arch index digest so it still works on arm64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
