siddubakka commented on PR #26123: URL: https://github.com/apache/datafusion/pull/26123#issuecomment-6151740310
hi @zhuqi-lucas @xudong963 — this is ready for review whenever you get a chance. for context, @rgbuilds reviewed the earlier rounds and approved after verifying the regression test passes with the guard and fails at swap_inputs without it. I also just resolved the merge conflict with main (upstream's StatisticsContext refactor touched the same function, re-applied the guards on top — cargo check passes on the lib and core_integration target). two things worth knowing: the semver bot failure is pre-existing on main (it's about pushdown_limit_helper_with_stats being removed in limit_pushdown.rs, not this PR — this diff only touches join_selection.rs + its test), and the red X on my merge commit is just a cancelled superseded run. the CI runs are also still waiting on approval. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
