rgbuilds commented on PR #26123: URL: https://github.com/apache/datafusion/pull/26123#issuecomment-6111858081
> @rgbuilds hey thanks for the review, fixed the fmt failure on that test signature > > and yeah you're right about the manual with_dynamic_filter_expr test — added one that runs FilterPushdown::new_post_optimization to wire up a real filter, then checks JoinSelection leaves it alone and the plan still returns the right rows Thanks—the formatting issue is fixed, and the real `FilterPushdown` wiring and execution check are helpful. One issue remains: both `TestScanBuilder` inputs report the same 123-byte size, so `should_swap_join_order` returns `false`. I confirmed that this test still passes when the statistical dynamic-filter guard is removed, because `JoinSelection` never attempts the problematic swap. Could we give the left/build side larger reported statistics than the right/probe side, or otherwise force `should_swap_join_order` to return `true`? It would also be helpful to assert that the original left and right children are preserved. Then the test should fail without the guard and pass with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
