ErikBPF commented on PR #6945: URL: https://github.com/apache/datafusion-comet/pull/6945#issuecomment-6159537258
Validation setup and the CI request, moved out of the description per review. **Current-head CI request.** The draft checks at `764896677` report `action_required` and await maintainer approval: - [Comet CI](https://github.com/apache/datafusion-comet/actions/runs/38465886987) - [CodeQL](https://github.com/apache/datafusion-comet/actions/runs/38465886674) - [Check PR Title](https://github.com/apache/datafusion-comet/actions/runs/38465886659) Please approve these fork runs and apply `run-delta-tests` for a hosted integration verdict. Label-only runs are advisory and do not replace required checks. **Local validation setup.** Upstream base `474b5ece841a7fc6dff37ae04bd6787e654d7be7`, Rust 1.98.1, Roaring 0.11.5, Linux. Initial checks used Java 21; an independent hash-verified checkout repeated the native validation on JDK 17 and ran the JVM suites. - `cargo fmt --all -- --check`: passed. - `cargo clippy --locked --all-targets --workspace -- -D warnings`: passed. - `cargo build --locked -p comet-test-udfs`, then `cargo test --locked -p datafusion-comet --lib`: 874 passed, 5 ignored, zero failures. The first run's 11 missing-fixture failures were resolved by building that documented shared-library fixture; no source or assertion workaround was applied. - Full-reactor `./mvnw -Pspark-4.1 compile -DskipTests`: passed. - The independent checkout passed the regression, DV and full core suites, fmt, clippy, native build and Spark 4.1 JVM compilation. Its isolated native target and Maven repository prevented cross-worktree artifact reuse; source hashes matched the reviewed candidate and the packaged Spark 4.1 JNI library matched its native build. - Temporary staging uses O(nonempty partitions) metadata; bitmap payloads are moved, not duplicated. No universal peak-memory claim is made. It then ran root-reactor `clean install -DskipTests`, followed by `test -Dtest=none -DwildcardSuites=<explicit Delta suites>` for each `-Pspark-<version>,delta`, without `-pl`. XML reports and explicit command exit statuses were checked: | Local integration scope | Passed | Canceled | Failed | | --- | ---: | ---: | ---: | | Spark 3.5: Delta scan, native scan, DML, plan injector | 277 | 1 | 0 | | Spark 4.0: same four suites | 278 | 0 | 0 | | Spark 4.1: same four suites | 278 | 0 | 0 | | Spark 3.5: required MinIO/S3 suite | 3 | 0 | 0 | Scope: these suites write and read portable-format deletion vectors, so they exercise the shared decoding path and confirm no regression there; the only cases that execute the changed native decoder are the two native unit tests. The canceled Spark 3.5 timestamp case explicitly requires Spark 4+ and passes on both 4.x profiles. `COMET_DELTA_S3_REQUIRED=1` prevented a false green from unavailable containers; all three S3 tests executed through rootless Podman. These are local integration results, not hosted CI approval or complete Spark SQL-suite coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
