comphead commented on code in PR #12266:
URL: https://github.com/apache/datafusion/pull/12266#discussion_r1739921615
##########
datafusion/sql/src/statement.rs:
##########
@@ -1588,6 +1592,37 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.statement_to_plan(rewrite.pop_front().unwrap()) // length of
rewrite is 1
}
+ fn show_functions_to_plan(
+ &self,
+ filter: Option<ShowStatementFilter>,
+ ) -> Result<LogicalPlan> {
+ if filter.is_some() {
Review Comment:
are we planning to apply the filter in future?
For example for SHOW now it is possible to display specific parameter like
```
show datafusion.execution.batch_size
```
I think it would be interesting to show the function by filter so ther user
can get the name and ideally the signature.
Later we can use this metadata table to obtain correct signature in unified
way instead of hardcoding signatures like now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
