kosiew commented on code in PR #25684:
URL: https://github.com/apache/datafusion/pull/25684#discussion_r4267779965
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -2796,6 +2797,88 @@ mod tests {
case_expression_nullability(false)
}
+ #[rstest::rstest]
+ #[case::and(Operator::And, false, false)]
+ #[case::or(Operator::Or, false, true)]
+ #[case::not_and(Operator::And, true, true)]
+ #[case::not_or(Operator::Or, true, false)]
+ fn test_case_expression_nullability_with_independent_columns(
Review Comment:
Could we also test mixed AND/OR recursion with `CASE WHEN a > 1 AND (b < 3
OR b IS NULL) THEN a ELSE 0 END` and its negated form? The first should be
non-nullable, while the second is nullable because `a = NULL, b = 3` makes the
negated condition TRUE. This would cover nested operators beyond the current
tests. Not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
