SrihariLegend commented on issue #25934: URL: https://github.com/apache/datafusion/issues/25934#issuecomment-6167627764
Hi @timsaucer , I'd like to work on this issue. Would you prefer seperate PRs for preserving existing aggregate builder options and tracking whether a window frame was set explicitly? Also one more question, is there a preference on whether the new flag participates in partialeq/hash, meaning should datafusion call them equal because their current calculation is identical? That can help the optimizer recognise and reuse a common expression. Or should it call them different because one has an explicit frame and the other doesnt? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
