mohitgurav20 commented on PR #25825: URL: https://github.com/apache/datafusion/pull/25825#issuecomment-6168964518
@kosiew you were right again — I traced the actual AggregateExec metrics output and found output_rows=100.0 K, appears before spill_count= in the metrics string. The leading <slt:ignore> was consuming output_rows=100.0 and the K, matched against output_rows=100.0 K, even with zero spills. Fixed in bd9034320: inserted spilled_bytes=<slt:ignore>, as a hard anchor between spill_count= and spilled_rows=, which matches the actual metric emission order and closes the false-positive path. The spilled_rows=100.0 K, literal in Cases A–F is now strict — a zero-spill run produces spilled_rows=0, with no K suffix, so the match fails. Applied the same spilled_bytes= anchor to Case G as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
