comphead commented on PR #6942: URL: https://github.com/apache/datafusion-comet/pull/6942#issuecomment-6174121927
@andygrove thanks for trying it on a mismatched classpath. You're right. The build I hit was hadoop-azure 3.4.2 on Hadoop 3.3.4, and there the only failure was the `FileSystem.newInstance` cross-check. The other 139 tests in `AbfsAuthParitySuite` passed. I then ran `AbfsAuthResolverSuite` and `NativeConfigSuite` on that classpath, and both pass. I tagged the other two suites without checking them first. I pushed the change you suggested: - `AzureTest` is now a ScalaTest `Tag` with the same name, `org.apache.comet.tags.AzureTest`, applied to that one test. The Java annotation and the suite-level annotations are gone. - The `development.md` note now describes just the cross-check, and says the resolver cases still run when it's skipped. Locally on the default profile, `-DtagsToExclude=org.apache.comet.tags.AzureTest` with the parity and resolver suites runs 178 tests, skipping only the cross-check. Without the flag, all 179 run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
