comphead opened a new pull request, #6942: URL: https://github.com/apache/datafusion-comet/pull/6942
## Which issue does this PR close? No issue is filed for this. It is a small follow-up to #6059. ## Rationale for this change `AbfsAuthParitySuite`, `AbfsAuthResolverSuite` and `AbfsScanFallbackSuite` resolve ABFS authentication through the `hadoop-azure` on the test classpath. They pass only when that `hadoop-azure` matches the Hadoop the build runs on. Every Spark profile in this repository pins a matching `hadoop-azure.version`, so CI is fine. A build against a different Hadoop line, such as a vendor Hadoop or an overridden `hadoop.version` without a matching `hadoop-azure.version`, fails these suites with `NoClassDefFoundError`. There was no way to skip them, because the root pom hard-codes the scalatest `tagsToExclude`, so `-DtagsToExclude` on the command line was ignored. ## What changes are included in this PR? - A new `org.apache.comet.tags.AzureTest` scalatest tag, applied to the three Azure suites. - A `tagsToExclude` property in the root pom, empty by default, appended to the `scalatest-maven-plugin` exclusions. `-DtagsToExclude=org.apache.comet.tags.AzureTest` now skips the Azure suites. `IntegrationTestSuite` stays excluded either way. - A note in the contributor guide's ABFS section. Nothing changes by default. The suites stay in both workflow lists and still run in CI. ## How are these changes tested? I ran these locally on the default profile with JDK 17, using `-Dsuites=org.apache.comet.objectstore.AbfsAuthParitySuite,org.apache.comet.objectstore.AbfsAuthResolverSuite`: - With `-DtagsToExclude=org.apache.comet.tags.AzureTest`: 0 tests run. - Without it: 179 tests pass, the same as before this change. I did not run `AbfsScanFallbackSuite` locally, because it needs the native library. `dev/ci/check-suites.py` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
