Weijun-H commented on code in PR #6968:
URL: https://github.com/apache/datafusion-comet/pull/6968#discussion_r4277737328
##########
spark/src/main/scala/org/apache/comet/serde/CometSortOrder.scala:
##########
@@ -46,26 +46,18 @@ import
org.apache.comet.serde.QueryPlanSerde.exprToProtoInternal
*/
object CometSortOrder extends CometExpressionSerde[SortOrder] {
- /**
- * Subjects of both the runtime fallback reasons and the generated
compatibility docs. Shared so
- * the two cannot describe the policy differently.
- */
- private val nestedNullOrderSort =
- "Sorting with `ASC NULLS LAST` or `DESC NULLS FIRST` on an array or struct
that can hold a " +
- "null element or field"
+ private val nondeterministicNestedKeyReason =
+ "A nested sort key with nondefault root null placement must be
deterministic"
Review Comment:
The reason now explains the double evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
