kosiew commented on code in PR #25628:
URL: https://github.com/apache/datafusion/pull/25628#discussion_r4280728062
##########
datafusion/sqllogictest/test_files/set_variable.slt:
##########
@@ -800,6 +800,32 @@ datafusion.execution.parquet.compression gzip(6)
statement ok
RESET datafusion.execution.parquet.compression
+# parquet.coerce_int96 is validated when it is set
Review Comment:
Could you add a SQL regression test that rejects `CREATE EXTERNAL TABLE ...
OPTIONS ('format.coerce_int96' 'nanos')` at CREATE time? Using an explicit
schema and an existing Parquet fixture would also cover the reported panic
path, which the current SET test doesn't exercise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
