geoffreyclaude commented on PR #25372: URL: https://github.com/apache/datafusion/pull/25372#issuecomment-6192538006
I found a performance follow-up: recalculating retained-buffer memory scans every merge input for each batch. #26366 makes these updates constant-time while preserving the reservations. The included SQL benchmark improves from 4.82 s to 1.30 s locally. @EmilyMatt and @andygrove, since you're obviously familiar with this part of the code, would you mind taking a look? 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
