1fanwang commented on code in PR #25767:
URL: https://github.com/apache/datafusion/pull/25767#discussion_r4284744990
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -1803,46 +1803,37 @@ async fn self_referential_except() -> Result<()> {
.await
}
+// `INTERSECT ALL` and `EXCEPT ALL` are planned with `unnest(range(..))` to
+// repeat each row, and the producer cannot serialize `Unnest` yet, so these
+// plans cannot be sent to Substrait. Consuming Substrait multiset set
+// operations still works (see `multiset_intersect_all_consume`).
#[tokio::test]
async fn self_referential_intersect_all() -> Result<()> {
- // Test INTERSECT ALL with the same table on both sides
- // INTERSECT ALL preserves duplicates and does not include DISTINCT
- // Uses **LeftSemi** join (returns rows from left that exist in right)
- // The requalification ensures no duplicate field name errors
- assert_expected_plan(
+ assert_unnest_not_supported(
Review Comment:
Done in
https://github.com/apache/datafusion/commit/4dc0cdd544912323f64d4340aabe901100f0149b.
Tracked in https://github.com/apache/datafusion/issues/26372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
