andygrove commented on PR #6835: URL: https://github.com/apache/datafusion-comet/pull/6835#issuecomment-6196262766
@kazuyukitanimura, the last round is in a2ad967e98, ddce25a6fe and 8e75130543. `adding_a_new_operator.md` has a new "Reporting an Output Ordering" section: an operator reports what the Spark operator reports, keeps it natively, and says so through `maintains_input_order`, or is added to `mayReportFalseOrder`. `CometSampleExec` was the example, and it no longer reports its child's order, as Spark's `SampleExec` doesn't, so the cache-through-sample case is fixed here and is not left for #6922. I'll take the sample sentence out of #6922. On the release, #6963 made the in-memory cache opt-in again, so the shapes left in #6922 no longer return sorted partitions with default settings on main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
