viirya commented on code in PR #6937:
URL: https://github.com/apache/datafusion-comet/pull/6937#discussion_r4286201701
##########
native/core/src/execution/operators/iceberg_dictionary.rs:
##########
@@ -1253,6 +1677,26 @@ mod tests {
);
}
+ /// The fields of a null struct are not part of the column chunk either.
+ #[test]
+ fn values_under_a_null_struct_are_not_counted() {
Review Comment:
I'd lean toward keeping `values_under_a_null_struct_are_not_counted`. It is
small and pins one property, so a failure points straight at the struct-null
check, where the sliced test would only show a different column list. It also
pairs with `values_under_a_null_list_are_not_counted`, which the sliced test
covers just as much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
