mbutrovich commented on code in PR #6937:
URL: https://github.com/apache/datafusion-comet/pull/6937#discussion_r4296031415
##########
native/core/src/execution/operators/iceberg_dictionary.rs:
##########
@@ -1253,6 +1677,26 @@ mod tests {
);
}
+ /// The fields of a null struct are not part of the column chunk either.
+ #[test]
+ fn values_under_a_null_struct_are_not_counted() {
Review Comment:
> I read the code to check this and did not run a mutation.
I ran the mutations on c2f688c4a8.
`a_sliced_batch_is_read_only_within_its_slice` fails on each of these, and no
other chooser test does:
- large-list offsets taken relative to the slice in
[`Children::start`](https://github.com/apache/datafusion-comet/blob/c2f688c4a8802e88d18e155f25a8b04f704e145b/native/core/src/execution/operators/iceberg_dictionary.rs#L449)
- the fixed-size-list start shifted by one element in
[`Children::start`](https://github.com/apache/datafusion-comet/blob/c2f688c4a8802e88d18e155f25a8b04f704e145b/native/core/src/execution/operators/iceberg_dictionary.rs#L450)
- the large list's null buffer ignored in
[`Leaf::path`](https://github.com/apache/datafusion-comet/blob/c2f688c4a8802e88d18e155f25a8b04f704e145b/native/core/src/execution/operators/iceberg_dictionary.rs#L379-L382)
- the fixed-size list's null buffer ignored in
[`Leaf::path`](https://github.com/apache/datafusion-comet/blob/c2f688c4a8802e88d18e155f25a8b04f704e145b/native/core/src/execution/operators/iceberg_dictionary.rs#L383-L386)
- either arm returning `None`, which leaves every column as configured
So `ll` and `fl` cover everything the removed half of
`reads_every_leaf_type` checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
