devtechedge commented on PR #2618: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2618#issuecomment-6197397202
Thanks, both reviews are addressed in 4e846e6. `parse_do` now follows `dostmt_opt_list` using your suggestion: any run of code blocks and `LANGUAGE` items, with the language as an identifier or any string literal, kept in source order as `Vec<DoOption>` so every form round-trips. I added all your test cases. I ran `fuzz_postgres_accepts` from the DO seeds for 8 minutes (about 4.4M execs) and nothing came from `DO` parsing. What it did turn up are older issues elsewhere: - odd operator expressions in `UPDATE … SET` (e.g. `! + 0`) - non-ASCII dollar-quote tags failing in the tokenizer, which also breaks `SELECT` Happy to look at those in separate PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
