devtechedge commented on PR #2618: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2618#issuecomment-6236343934
Thank you for the detailed review and for the suggested fix, I really appreciate it. I will add the test in the Postgres suite and implement the `N'...'` handling as you described. I will also check for any other `DO` forms I may have missed. So I can plan my time well, could you please give me a rough idea of how many more rounds of changes you expect for this PR? I am very happy to keep iterating until you are satisfied with it, and a rough sense of the remaining scope will simply help me plan and make sure I cover everything carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
