alamb commented on code in PR #26329:
URL: https://github.com/apache/datafusion/pull/26329#discussion_r4283072448
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -1491,6 +1495,45 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_one_of_signature_mismatch_is_not_an_internal_error() {
Review Comment:
If you think we need more coverage, please adapt this test to .slt
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -1491,6 +1495,45 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_one_of_signature_mismatch_is_not_an_internal_error() {
Review Comment:
I think we can remove this unit test as the .slt tests cover all the same
paths, right? It seems like we don't need double coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
