DeviousCardi opened a new pull request, #2641:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2641
Fixes #2446.
`CREATE TRIGGER ... EXECUTE FUNCTION audit_row('api_key')` (and the `EXECUTE
PROCEDURE` spelling) failed with `Expected: a data type name, found:
'api_key'`, because the call was parsed as a function declaration
(`FunctionDesc`), whose arguments are data types.
`TriggerExecBody` now stores the function `name` and `args:
Option<Vec<Expr>>` instead of `func_desc: FunctionDesc`, so arguments are
parsed as expressions and round-trip through `Display`. `None` keeps the
existing no-parentheses form. This is a breaking change to the public
`TriggerExecBody` struct; the MySQL and PostgreSQL tests are updated for it.
New tests cover zero, one and several arguments (strings, numbers, a bare
name) for both keywords, plus an unclosed argument list.
PostgreSQL docs:
https://www.postgresql.org/docs/current/sql-createtrigger.html
AI disclosure: this change was prepared with AI assistance (Claude Code).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Y1b55sEL1gA1c3FCMcQCbm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]