U0001F3A2 commented on PR #23676: URL: https://github.com/apache/datafusion/pull/23676#issuecomment-6206541330
Thanks for the suggestion! I tested the width-specific signatures, and they fix the execution issue, so the runtime casts can be removed. The return-type and simplification fixes are still needed: simplify can see uncoerced arguments, and log(Float16 base, Float64 1) otherwise produces a Float16 zero. I also added typed-NULL handling so log(NULL, 1) stays NULL. The local candidate passes 339 function tests and the math/scalar SQL tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
