github-actions[bot] commented on PR #26410:
URL: https://github.com/apache/datafusion/pull/26410#issuecomment-6212311595

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-common v55.1.0 (current)
          Built [  21.800s] (current)
        Parsing datafusion-common v55.1.0 (current)
         Parsed [   0.047s] (current)
       Building datafusion-common v55.1.0 (baseline)
          Built [  21.527s] (baseline)
        Parsing datafusion-common v55.1.0 (baseline)
         Parsed [   0.047s] (baseline)
       Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch)
        Checked [   0.530s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip
   
   --- failure struct_pub_field_missing: pub struct's pub field removed or 
renamed ---
   
   Description:
   A publicly-visible struct has at least one public field that is no longer 
available under its prior name. It may have been renamed or removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/struct_pub_field_missing.ron
   
   Failed in:
     field enable_join_integer_prefilter of struct ExecutionOptions, previously 
in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/e2803d65a59ed8ceb4ac3f1c37f866e1bdceb3ae/datafusion/common/src/config.rs:897
     field join_integer_prefilter_max_key_range of struct ExecutionOptions, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/e2803d65a59ed8ceb4ac3f1c37f866e1bdceb3ae/datafusion/common/src/config.rs:897
     field join_integer_prefilter_min_pruning_ratio of struct ExecutionOptions, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/e2803d65a59ed8ceb4ac3f1c37f866e1bdceb3ae/datafusion/common/src/config.rs:897
     field join_integer_prefilter_sample_rows of struct ExecutionOptions, 
previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/e2803d65a59ed8ceb4ac3f1c37f866e1bdceb3ae/datafusion/common/src/config.rs:897
   
        Summary semver requires new major version: 1 major and 0 minor checks 
failed
       Finished [  45.473s] datafusion-common
       Building datafusion-optimizer v55.1.0 (current)
          Built [  16.581s] (current)
        Parsing datafusion-optimizer v55.1.0 (current)
         Parsed [   0.023s] (current)
       Building datafusion-optimizer v55.1.0 (baseline)
          Built [  16.565s] (baseline)
        Parsing datafusion-optimizer v55.1.0 (baseline)
         Parsed [   0.024s] (baseline)
       Checking datafusion-optimizer v55.1.0 -> v55.1.0 (no change; assume 
patch)
        Checked [   0.130s] 229 checks: 229 pass, 31 skip
        Summary no semver update required
       Finished [  34.138s] datafusion-optimizer
       Building datafusion-physical-plan v55.1.0 (current)
          Built [  22.729s] (current)
        Parsing datafusion-physical-plan v55.1.0 (current)
         Parsed [   0.137s] (current)
       Building datafusion-physical-plan v55.1.0 (baseline)
          Built [  22.671s] (baseline)
        Parsing datafusion-physical-plan v55.1.0 (baseline)
         Parsed [   0.136s] (baseline)
       Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume 
patch)
        Checked [   0.479s] 229 checks: 229 pass, 31 skip
        Summary no semver update required
       Finished [  47.486s] datafusion-physical-plan
       Building datafusion-sqllogictest v55.1.0 (current)
          Built [  59.608s] (current)
        Parsing datafusion-sqllogictest v55.1.0 (current)
         Parsed [   0.012s] (current)
       Building datafusion-sqllogictest v55.1.0 (baseline)
          Built [  60.138s] (baseline)
        Parsing datafusion-sqllogictest v55.1.0 (baseline)
         Parsed [   0.013s] (baseline)
       Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume 
patch)
        Checked [   0.076s] 229 checks: 229 pass, 31 skip
        Summary no semver update required
       Finished [ 121.926s] datafusion-sqllogictest
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to