alamb opened a new pull request, #26419: URL: https://github.com/apache/datafusion/pull/26419
## Which issue does this PR close? N/A ## Rationale for this change Each `.rs` file directly in `datafusion/core/tests` becomes its own test binary, which means tens of MB (here hundreds of MB) of extra binary, extra link time, and tests that cannot run in parallel with tests in other binaries. This follows the same rationale as earlier consolidations (#10588, #11831, #18226). With a normal debug build (`cargo test -p datafusion --test set_comparison --no-run`) the standalone `set_comparison` binary is **389 MB** (407,691,392 bytes) on my machine (macOS, aarch64) to run just 6 small tests. ## What changes are included in this PR? Move `datafusion/core/tests/set_comparison.rs` to `datafusion/core/tests/sql/set_comparison.rs` and register it in `sql/mod.rs`, so it is built as part of `core_integration`. Size of `core_integration` (debug build): | | bytes | |---|---| | before | 457,079,488 | | after | 457,223,744 (+144 KB) | So this saves creating a ~389 MB binary at a cost of ~144 KB in `core_integration`. ## What is the testing strategy for this PR? The tests are unchanged and are run by `core_integration`: ```shell cargo test -p datafusion --test core_integration -- set_comparison ``` All 6 tests pass. `cargo fmt` and `cargo clippy` pass. ## Are there any user-facing changes? No, developer productivity only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
