alamb opened a new pull request, #26422: URL: https://github.com/apache/datafusion/pull/26422
## Which issue does this PR close? N/A ## Rationale for this change Each `.rs` file directly in `datafusion/core/tests` becomes its own test binary, which means extra binary size, extra link time, and tests that cannot run in parallel with tests in other binaries. This follows the same rationale as earlier consolidations (#10588, #11831, #18226) and my previous #26419. With a normal debug build the standalone `tpcds_planning` binary is **390 MB** (408,695,296 bytes) on my machine (macOS, aarch64). ## What changes are included in this PR? Move `datafusion/core/tests/tpcds_planning.rs` to `datafusion/core/tests/sql/tpcds_planning.rs` and register it in `sql/mod.rs`, so it is built as part of `core_integration`. The tests are unchanged. Debug binary sizes: | binary | bytes | |---|---| | `tpcds_planning` (removed) | 408,695,296 | | `core_integration` before | 457,595,344 | | `core_integration` after | 458,314,960 (+703 KB) | So this avoids building and linking a ~390 MB binary at a cost of ~703 KB in `core_integration`. ## What is the testing strategy for this PR? The tests are unchanged and are run by `core_integration`: ```shell cargo test -p datafusion --test core_integration -- tpcds ``` All 198 tests pass. `cargo fmt` and `cargo clippy` pass. ## Are there any user-facing changes? No, developer productivity only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
