HairstonE commented on PR #26211: URL: https://github.com/apache/datafusion/pull/26211#issuecomment-6225059007
@jdymitarai Two small nits before I approve. The testing section references `single_distinct_to_group_by.rs`, but the file name ends in `groupby`, with no underscore. I would argue that the Decimal128 output now matching the original declared output type is a user-facing change, because it changes a returned value's type. Could you update the "user-facing changes" answer to address that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
