Phoenix500526 commented on code in PR #25279:
URL: https://github.com/apache/datafusion/pull/25279#discussion_r4302176408
##########
datafusion/datasource/src/file_scan_config/mod.rs:
##########
@@ -615,15 +617,52 @@ impl From<FileScanConfig> for FileScanConfigBuilder {
}
}
-/// Builds output partitioning over `partition_cols` (resolved to their
indices in
-/// `schema`) with `partition_count` partitions. Returns `None` when there are
no
-/// partition columns. Callers use this to declare the output partitioning of
a scan
-/// whose file groups are organized by partition column values.
+/// Builds `Partitioning::Hash` over `partition_cols` (resolved to their
indices in
+/// `schema`). Returns `None` when there are no partition columns.
+#[deprecated(
+ since = "56.0.0",
+ note = "Use `output_range_partitioning_from_split_points` instead"
+)]
Review Comment:
Should we add a short migration example to the 56.0.0 upgrade guide covering
the new `ListFilesResult` field and the replacement for the deprecated Hash
helper? It would help clarify how to derive split points from the file groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
