txwyy123 commented on PR #26149: URL: https://github.com/apache/datafusion/pull/26149#issuecomment-6245967481
@jayzhan211 Thanks for the excellent refactor! I merged your PR (txwyy123/datafusion#1) into the branch — the split into add-only `RecordBatchMemoryCounter` + refcounted `RecordBatchMemoryTracker` is a much cleaner design. All checks pass locally: - `cargo fmt` ✅ - `cargo clippy -p datafusion-common -p datafusion-physical-plan --all-targets --all-features -- -D warnings` ✅ - 24 memory tests ✅ - 119 TopK tests ✅ The branch is updated and ready for CI. Could you trigger the first-time-contributor workflow approval and review when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
