Braedon-Wooding-Displayr opened a new pull request, #26474: URL: https://github.com/apache/datafusion/pull/26474
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #26473 ## Rationale for this change `find_exprs_in_exprs` and `find_exprs_in_expr` deduplicate with `Vec::contains`, which is quadratic in the number of distinct matches. On 20,000 distinct aggregates `find_aggregate_exprs` takes 932 ms; with this change it takes 2.8 ms (release build, see the issue for the full table). ## What changes are included in this PR? Both functions now collect into a single index set. ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
