adriangb commented on PR #26105: URL: https://github.com/apache/datafusion/pull/26105#issuecomment-6250069320
The issue is the new metric values are wrong for view arrays that share buffers, right? I’d rather have either an accurate metric or no metric over always on wrong metric. The alternative I propose is that we add a config flag that allows opting into one of (1) switch between exact and approx for this metric or (2) enable or disable the exact version of this metric. > Making output_bytes a Dev/verbose metric wouldn't remove the cost on its own: MetricType only filters what AnalyzeExec displays, and record_output still runs for every batch Is that something we could fix? Seems like there might be potential there for other wins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
