sunchao commented on code in PR #7082: URL: https://github.com/apache/datafusion-comet/pull/7082#discussion_r4315411553
########## spark/src/test/scala/org/apache/comet/exec/CometSharedMetadataCacheRestartSuite.scala: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.exec + +import java.io.File +import java.nio.file.{Files, Paths, StandardCopyOption} + +import org.scalatest.funsuite.AnyFunSuite + +import org.apache.commons.io.FileUtils +import org.apache.spark.sql.SparkSession + +/** + * The native Parquet scan shares a footer cache between the tasks of a stage in a registry that + * lives as long as the JVM. Stage ids restart at zero in every SparkContext, so a context started + * after another one stopped must not be handed the footers the old one left in it. + * + * Runs its own contexts, which is why it is not part of a suite that shares a session. + */ +class CometSharedMetadataCacheRestartSuite extends AnyFunSuite { Review Comment: [P2] [P2] Register the restart suite in both CI matrices. This new suite is absent from `.github/workflows/pr_build_linux.yml` and `.github/workflows/pr_build_macos.yml`. Adding it causes the mandatory suite-discovery check to exit 255 instead of allowing CI to proceed. At this exact head, that fails `Preflight` and `Required Checks`, skips the build and regression jobs, and leaves the restart test without CI coverage. Please add its fully qualified name to an appropriate suite group in both workflows. Evidence: Locally, `python dev/ci/check-suites.py` exits 255 with `Suite not found in workflow .github/workflows/pr_build_linux.yml: org.apache.comet.exec.CometSharedMetadataCacheRestartSuite`. Both workflow files lack the suite name. Exact-head CI reports the same failure: https://github.com/apache/datafusion-comet/actions/runs/39167082870/job/117792161514. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
