viirya commented on PR #26213: URL: https://github.com/apache/datafusion/pull/26213#issuecomment-6280389419
Thanks @comphead, addressed in 785332e66: renamed `marked_row` to `unknown_row` (and `decided_rows` in the cross-product helper), renamed the build flags to `with_null_candidate_state` / `with_build_unknown_bitmap` with a comment that the former also covers a multi-column key without scope keys, and `process_probe_batch` now matches on `NullAwareMode::RightAnti`. Thanks @sunchao for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
