viirya commented on code in PR #7112: URL: https://github.com/apache/datafusion-comet/pull/7112#discussion_r4321655567
########## spark/src/test/scala/org/apache/spark/sql/benchmark/CometIcebergWriteBenchmark.scala: ########## @@ -61,7 +61,7 @@ import org.apache.comet.CometSparkSessionExtensions * pay equally. It dilutes the writer's factor rather than inflating it. * - The warehouse is a local temporary directory, so no object-store latency is included. * - The two writers choose different file roll points (see the accepted divergences in - * `docs/source/user-guide/latest/iceberg-writes.md`), so the resulting file layouts are not + * `docs/source/user-guide/dev/iceberg-writes.md`), so the resulting file layouts are not Review Comment: Thanks for the updates, they all look good. The new CI failures all come from one spotless violation: scalafmt wants this comment line (and the same one in `CometIcebergEndToEndBenchmark.scala`) rewrapped, so `of` moves to the next line. Running `make format` (or `./mvnw spotless:apply`) and committing should clear every failing job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
