alamb commented on code in PR #26476:
URL: https://github.com/apache/datafusion/pull/26476#discussion_r4329321684


##########
datafusion/datasource-parquet/src/opener/mod.rs:
##########
@@ -2690,6 +2702,26 @@ mod test {
         }
     }
 
+    /// Drives a [`ParquetMorselizer`] to completion and returns how many
+    /// morsels it produced.
+    async fn count_morsels(

Review Comment:
   please do #cfg(test)



##########
datafusion/datasource-parquet/src/opener/mod.rs:
##########
@@ -660,6 +660,14 @@ impl ParquetOpenState {
             }
             ParquetOpenState::PruneWithStatistics(prepared) => {
                 let mut prepared_row_groups = (*prepared).prune_row_groups()?;
+                if prepared_row_groups
+                    .row_groups
+                    .row_group_indexes()

Review Comment:
   maybe could check with empty()?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to