dwsmith1983 commented on code in PR #5867:
URL: https://github.com/apache/datafusion-comet/pull/5867#discussion_r4332724045
##########
spark/src/test/scala/org/apache/comet/CometMapExpressionSuite.scala:
##########
@@ -388,30 +388,33 @@ class CometMapExpressionSuite extends CometTestBase {
// Finding E: a map nested inside a map value is handed to the JVM
dispatcher whole, so its double
// keys never revisit `CometLiteral`. The guard has to live on the lookup
instead. The outer key
- // type is INT, so inspecting only the outermost map would admit the query;
the fallback comes
- // from the inner `element_at`, whose child is `MapType(DoubleType,
IntegerType)`. Constant folding
- // is on here, which is the only configuration where the inner map becomes
such a literal, so this
- // regression cannot be expressed in a SQL fixture (the harness disables
folding). The direct
- // single-level double-key lookups live in `element_at_map.sql` /
`get_map_value.sql`.
- test("nested map lookup with floating-point keys falls back") {
+ // type is INT, so inspecting only the outermost map would admit the query;
the dispatch comes
+ // from the `element_at` whose child is `MapType(DoubleType, IntegerType)`,
which takes the whole
+ // nested lookup with it. Constant folding is on here, which is the only
configuration where the
+ // inner map becomes such a literal, so this regression cannot be expressed
in a SQL fixture (the
+ // harness disables folding). The direct single-level double-key lookups
live in
Review Comment:
You're right, the header exists. The five "is dispatched" tests moved to
`map_lookup_folded_literal.sql` with `-- ConstantFolding: enabled`, and the two
collated ones to a 4.0+ variant. All five reproduce there, and the suite tests
and the wrong sentence are gone in e3a5cd2b7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
