andygrove opened a new pull request, #7166:
URL: https://github.com/apache/datafusion-comet/pull/7166

   ## Which issue does this PR close?
   
   N/A - documentation fix found while cutting the 1.2.0 release branch.
   
   ## Rationale for this change
   
   `contrib/delta-spark/pom.xml` was added after 1.1.0. Its parent version must 
match the root pom, so it has to change in the release branch version bump 
(`X.Y.Z-SNAPSHOT` to `X.Y.Z`) and in the bump on `main` for the next cycle. The 
[release 
process](https://github.com/apache/datafusion-comet/blob/main/docs/source/contributor-guide/release_process.md#update-maven-version)
 lists the `pom.xml` files by name and does not include it. Both steps point at 
that one list, so following the doc literally leaves the module's parent 
pointing at a version the root pom no longer has.
   
   ## What changes are included in this PR?
   
   - Add `contrib/delta-spark/pom.xml` to the list of `pom.xml` files in 
"Update Maven Version". The "Update Version in main" step refers to the same 
list.
   - Note that the `git grep` check after the bump also catches a module added 
since the last release that the list does not name yet.
   
   ## How are these changes tested?
   
   Documentation only. `prettier --check` passes on the file. The 1.2.0 version 
bump in #7165 changed this file and the other four `pom.xml` files, and `./mvnw 
validate` passed on that branch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to