mbutrovich commented on code in PR #7166: URL: https://github.com/apache/datafusion-comet/pull/7166#discussion_r4359851966
########## docs/source/contributor-guide/release_process.md: ########## @@ -206,6 +209,30 @@ Create a PR against the main branch to prepare for developing the next release: - Update the Maven version to `0.14.0-SNAPSHOT` in the same set of files listed above (the `pom.xml` files, the Spark test diffs under `dev/diffs`, and the Iceberg test diffs under `dev/diffs/iceberg`). +### Refresh Dependencies in main + +Once the version bump has merged, refresh the native dependencies in a separate PR against the main branch. Doing +it at the start of the cycle gives the new versions the full cycle of nightly and merge queue runs before the next +release branch is cut. The release branch keeps the lockfile it was cut with, so it ships the dependency set that CI +has been testing. Keep this PR apart from the version bump so that a regression is easy to bisect and revert. + +Run `cargo update` in `native/` and in each contrib crate that has its own `Cargo.lock`, then check the build: + +```shell +cd native && cargo update && cargo check --all-targets --locked +cd ../contrib/delta/native && cargo update && cargo check --all-targets --locked +``` + +Dependabot already opens weekly PRs for `native/`, but it ignores major `arrow*`, `parquet` and `datafusion*` bumps, +which are handled manually, and it does not cover the contrib crates or transitive dependencies that `cargo update` +moves within their semver range. It also does not move git-pinned dependencies such as `iceberg-rust`, whose `rev` in +`native/Cargo.toml` needs a deliberate bump. Review Comment: Will an agent misinterpret this as an instruction to deliberately bump `datafusion` etc.? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
