andygrove opened a new pull request, #7167:
URL: https://github.com/apache/datafusion-comet/pull/7167

   ## Which issue does this PR close?
   
   N/A. This is a release process task, the ["Update Version in 
main"](https://github.com/apache/datafusion-comet/blob/main/docs/source/contributor-guide/release_process.md#update-version-in-main)
 step.
   
   ## Rationale for this change
   
   `branch-1.2` has been cut, so `main` should move on to the next development 
version.
   
   ## What changes are included in this PR?
   
   Per the release process documentation:
   
   - Maven version `1.2.0-SNAPSHOT` -> `1.3.0-SNAPSHOT` in `pom.xml`, 
`common/pom.xml`, `spark/pom.xml`, `spark-integration/pom.xml`, and 
`contrib/delta-spark/pom.xml`. The last one is not in the release process's 
file list yet; #7166 adds it.
   - `<comet.version>` in the Spark test diffs (`dev/diffs/3.4.3.diff`, 
`3.5.9.diff`, `4.0.4.diff`, `4.1.3.diff`, `4.2.0.diff`).
   - The `comet` Gradle version catalog entry in the Iceberg test diffs 
(`dev/diffs/iceberg/1.8.1.diff`, `1.9.1.diff`, `1.10.0.diff`, `1.11.0.diff`).
   - Rust crate version `1.2.0` -> `1.3.0` in `native/Cargo.toml`, with 
`native/Cargo.lock` regenerated by `cargo update --workspace --offline`. Only 
the 13 Comet crate versions in the lockfile change, and no dependency versions 
move.
   
   This also bumps the two contrib crates. They sit outside the `native/` 
workspace, so they don't inherit its version:
   
   - `contrib/lance/native/Cargo.toml`: `1.2.0` -> `1.3.0`. It has no lockfile.
   - `contrib/delta/native/Cargo.toml`: `1.2.0` -> `1.3.0`, with its standalone 
`Cargo.lock` regenerated the same way. It changes by two lines, the 
`comet-contrib-delta` and `datafusion-comet-proto` versions.
   
   The diffs were regenerated from patched Spark and Iceberg checkouts rather 
than edited by hand. So each one also updates the blob hash on the `index` line 
of the file whose version changed (`pom.xml` or `gradle/libs.versions.toml`), 
and that is the only other line that changes. Before the change, every diff 
regenerated byte-for-byte from its tag, so the regeneration carries no 
unrelated drift.
   
   ## How are these changes tested?
   
   - `git grep -n '1.2.0-SNAPSHOT' -- . ':!docs/source/changelog'` returns no 
hits.
   - `./mvnw validate` passes, and `help:evaluate -Dexpression=project.version` 
reports `1.3.0-SNAPSHOT`.
   - `cargo metadata --locked --offline` passes for both `native/` and 
`contrib/delta/native/`, so each lockfile is consistent with the bumped 
manifests.
   - Each new diff applies cleanly to a fresh checkout of its Spark or Iceberg 
tag, and regenerating it from there reproduces the committed file byte-for-byte 
before the version edit.
   
   Otherwise existing CI. The Spark SQL and Iceberg workflows are the ones that 
apply these diffs and build against the new version. On a `main` pull request 
they run only with the `run-spark-*-tests` and `run-iceberg-tests` labels.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to