yashaggarwal85d commented on PR #26637: URL: https://github.com/apache/datafusion/pull/26637#issuecomment-6380136045
> Thanks for the thorough review! I rebased on main, which fixes the `cargo-semver-checks` failure (the old base didn't have `input_keeps_groups_local`), and pushed a commit addressing the inline comments: > > - **Fall-through:** both streams now keep the refused reservation and fall through to the normal emit path. The duplicated tail and the shadowed `e` are gone. > - **Shared helper:** the driver now lives in a `#[cfg(test)] clustered_test_util` module that all three clustered streams use (`clustered_partial_stream.rs` too). The tests have consistent names in each module: `fully_clustered_completed_groups_under_memory_pressure`, `memory_pressure_without_completed_groups`, `partially_clustered_memory_pressure_without_spilling`. > - **Comments:** I trimmed the stage-list addition. What remains is the type doc and one short inline note per stream. > > I didn't do the randomized/fuzz variant in this PR, to keep it focused. I'm happy to send it as a follow-up that extends the aggregate fuzz cases with multi-batch, multi-column and string keys, if that works for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
