jayzhan211 commented on PR #26562: URL: https://github.com/apache/datafusion/pull/26562#issuecomment-6380821683
> wondering should we test variants other than `Single` and `Final`? FinalPartitioned and SinglePartitioned run the same streams as Final and Single, so they would repeat these sequences. Partial is already covered: unclustered in `output_materialization_refused`, and clustered in `clustered_partial_emits_completed_groups_whole` and `full_clustering_refusal_is_an_error`. That leaves PartialReduce. Its own unit tests already fail on each change I tried to its early emit, so I left it out here. Its refused output materialization (ignored, like Partial) has no test yet, and I can add a PartialReduce case to `output_materialization_refused` in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
