zhuqi-lucas commented on issue #26481: URL: https://github.com/apache/datafusion/issues/26481#issuecomment-6394093455
Thanks @jayzhan211 for the detailed proposal — the end state matches what #25688 is aiming for, and landing it as step 1 with today's rule order sounds right to me. On the three changes for #25688: agreed on the executable check at the boundary (good catch on the FFI session silently skipping `physical_analyzers`) and on running the `OutputRequirements` remove step from the planner — I'll update the PR for both. For `EliminateConstantJoin` I'd put it in the optimizer: it's a performance rewrite, and keeping it in the analyzer only because it currently runs before `JoinSelection` would blur the boundary this epic is trying to draw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
