marvelefe commented on issue #26658: URL: https://github.com/apache/datafusion/issues/26658#issuecomment-6396817353
Hi @jayzhan211, I'd like to pick this up. I traced the overflow to the unchecked additions in datafusion/physical-optimizer/src/limit_pushdown_past_window.rs: `fetch + ctx.lookahead` (L198/L199), `fetch + limit.skip()` (L206), and `ctx.lookahead + max_rel` (L180). I'd switch these to `saturating_add` (matching sort_pushdown.rs) and add a sqllogictest case in window_limits.slt with a large `ROWS ... FOLLOWING`. Prefer saturation, or an explicit planner error on overflow? Could you assign me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
